Repository navigation
feat(scheduler): heartbeat-aware health check for scheduled sync - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The HTTP-based image HEALTHCHECK is only suitable for the web process. PR #8 disabled it for scheduler as a short-term correction. This follow-up adds a scheduler-specific, non-HTTP heartbeat/deadline check.
Implementation
data/scheduler_heartbeat.json(0600): PID, start/heartbeat timestamps, sleep vs running, next scheduled run, previous completed run start/end and return code.--oncejobs sharing the same mounteddatadirectory.scheduler.healthcheck.disable: truewith a Python-based Compose healthcheck. Keep the web image's HTTP healthcheck unchanged.Deployment and caution
This is a separate follow-up to merged PR #8, not a hotfix to the currently running OCI container. Rebuild the image and recreate services only after CI and review. Docker's unhealthy status does not automatically restart containers; configure monitoring separately.
Validation
GitHub CI: Python tests, frontend build, Docker smoke, history secret scan.